I bought some shocks that have pits and rust on the chrome, I want to recondition them as well as possible. Returning them to new condition will be impossible but whats the best way to make them look the best they can?
Solvent, polish, ?
Seviersavage

Hit them with a good penetrating oil to break the rust down. Let them stay wet a few days if it takes that long to get the deepest rust soaking.
Amazing as it seems ,, Wintergreen OIl walks thru the tightest cracks & loosens nuts on bolts up, so, I expect it would seep into rust, too.
A steel wire brush will screw it up, but brass is okay on chrome. Brush the rust out.

Many rust treatments out there. I like Ospho, its a dilute phosphoric acid & converts iron oxide to iron phosphate, thus, killing the rust.

I dont think it hurts chrome, but Im not sure. Seems I wiped some on a chrome bumper once but you better check on something you dont care about before you go hog wild.
Ospho is about $12.00 a quart, at Kelly Moore paint stores. A quart lasted me for 7 or 8 years, I finally got  a new one.  I just keep some around for killing rust in places I dont like rust being,, thats anywhere at all.

Hit it with some S.O.S cleaning pads. That stuff works wonders on chrome.

I like the idea of using coke and aluminum foil   make sense if you figure that coke has an acidic effect and can dissolve some metals over time. i've used the plastic scrubber side of a dish sponge, but it leaves some marks too. if you really want it to look nice though, use a chrome polish/protector, or if its stubborn soak it in solvent, a fine steel wool, and polishing after.